mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 65363: Improved the validation of `ACKNOWLEDGE_OPERATION_STATUS` calls.
Date Wed, 07 Feb 2018 22:20:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65363/#review197053
-----------------------------------------------------------


Fix it, then Ship it!





src/master/validation.cpp
Lines 614 (patched)
<https://reviews.apache.org/r/65363/#comment277158>

    s/affcting/affecting/
    
    I can fix this while committing.


- Greg Mann


On Feb. 1, 2018, 11:50 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65363/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2018, 11:50 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-8184
>     https://issues.apache.org/jira/browse/MESOS-8184
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Improved the validation of `ACKNOWLEDGE_OPERATION_STATUS` calls.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.cpp f0b86775b7919ba6aa4a73038edb78a0adca68f4 
> 
> 
> Diff: https://reviews.apache.org/r/65363/diff/2/
> 
> 
> Testing
> -------
> 
> `make check` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message