mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 65522: Fixed some log messages in `slave.cpp`.
Date Wed, 07 Feb 2018 21:48:50 GMT


> On Feb. 6, 2018, 6:29 p.m., Gaston Kleiman wrote:
> > src/slave/slave.cpp
> > Line 9530 (original), 9529 (patched)
> > <https://reviews.apache.org/r/65522/diff/1/?file=1953214#file1953214line9530>
> >
> >     I noticed that if a single task is passed, we surround its ID in single quotes,
but we don't do that if a task groups is passed.
> >     
> >     We might want to do this consistently.
> 
> Chun-Hung Hsiao wrote:
>     Would you prefer iterating throuch each ID and qouting them, or add a pair of brackets
surrounding them?
> 
> Gaston Kleiman wrote:
>     I'd vote for the former.

Reverted this change for now since not everyone agrees on this one.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65522/#review196906
-----------------------------------------------------------


On Feb. 7, 2018, 6:45 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65522/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2018, 6:45 p.m.)
> 
> 
> Review request for mesos, Gaston Kleiman and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed some log messages in `slave.cpp`.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp a6a5c93ab2d541c870cb52587495de20ed5ac1f4 
> 
> 
> Diff: https://reviews.apache.org/r/65522/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message