mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 62800: Created cgroups under systemd hierarchy in LinuxLauncher.
Date Wed, 07 Feb 2018 20:01:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62800/
-----------------------------------------------------------

(Updated Feb. 7, 2018, 8:01 p.m.)


Review request for mesos, James Peach, Joris Van Remoortere, and Joseph Wu.


Changes
-------

Rebased.


Bugs: MESOS-7990
    https://issues.apache.org/jira/browse/MESOS-7990


Repository: mesos


Description (updated)
-------

This patch added the support for systemd hierarchy in LinuxLauncher.
It created the same cgroup layout under the systemd hierarchy (if
systemd is enabled) as that in the freezer hierarchy.

This can give us a bunch of benefits:
1) systemd-cgls can list mesos container processes.
2) systemd-cgtop can show stats for mesos containers.
3) Avoid the pid migration issue described in MESOS-3352.

For example:

```
[jie@core-dev ~]$ systemd-cgls
|-1 /usr/lib/systemd/systemd --system --deserialize 20
|-mesos
|  |-8282b91a-5724-4964-a623-7c6bd68ff4ad
|  |-31737 /usr/libexec/mesos/mesos-containerizer launch
|  |-31739 mesos-default-executor --launcher_dir=/usr/libexec/mesos
|  |-mesos
|     |-8555f4af-fa4f-4c9c-aeb3-0c9f72e6a2de
|       |-31791 /usr/libexec/mesos/mesos-containerizer launch
|       |-31793 sleep 1000
```


Diffs (updated)
-----

  src/slave/containerizer/mesos/linux_launcher.cpp c2e319894874e628beda6dc305462af0c274fd7b



Diff: https://reviews.apache.org/r/62800/diff/2/

Changes: https://reviews.apache.org/r/62800/diff/1-2/


Testing
-------

sudo make check

I also use the steps describe in MESOS-3352 to repo the systemd pid migration issue. Didn't
observe it after applying the patch.


Thanks,

Jie Yu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message