mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 65538: Added provider assignments into `disk_profile.proto`.
Date Wed, 07 Feb 2018 18:55:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65538/#review197009
-----------------------------------------------------------


Fix it, then Ship it!




Can you update the summary and description of this review accordingly?


src/resource_provider/storage/disk_profile.proto
Line 32 (original), 51 (patched)
<https://reviews.apache.org/r/65538/#comment277120>

    I don't change the tag number.


- Jie Yu


On Feb. 7, 2018, 6:51 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65538/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2018, 6:51 p.m.)
> 
> 
> Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-8510
>     https://issues.apache.org/jira/browse/MESOS-8510
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> A new `assignments` field is added to the `DiskProfileMapping` protobuf
> so that the URI disk profile adaptor can be customized to notify each
> resource provider a different set of profiles.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/disk_profile.proto 6cf1f8abcd24e45a292efc95a395f90bb2140da2

> 
> 
> Diff: https://reviews.apache.org/r/65538/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message