mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 65545: Start from merge-base when posting reviews.
Date Wed, 07 Feb 2018 15:24:24 GMT


> On Feb. 7, 2018, 2:35 p.m., Benno Evers wrote:
> > support/post-reviews.py
> > Lines 202 (patched)
> > <https://reviews.apache.org/r/65545/diff/1/?file=1953931#file1953931line202>
> >
> >     I'm tempted to make this fatal, since I cannot imagine a good reason why anyone
would want to still post the review, but I wanted to ask for other opinions first.

After discussion with @bbannier, changed the behaviour to warn about the issue and attempt
to do the right thing afterwards.


- Benno


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65545/#review196990
-----------------------------------------------------------


On Feb. 7, 2018, 3:22 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65545/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2018, 3:22 p.m.)
> 
> 
> Review request for mesos, Armand Grillet and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When posting a review originally created from a branch B, it could happen that the resulting
review included garbage changes if B was updated between revisions. (i.e., pulling new master
changes)
> 
> This review changes the logic of the `post-reviews.py` script to only include the changes
between `HEAD` and the merge base of the tracking branch into the review.
> 
> 
> Diffs
> -----
> 
>   support/post-reviews.py 94b43253f25044a79009010e92363d1536c74299 
> 
> 
> Diff: https://reviews.apache.org/r/65545/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message