mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 65545: Start from merge-base when posting reviews.
Date Wed, 07 Feb 2018 15:22:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65545/
-----------------------------------------------------------

(Updated Feb. 7, 2018, 3:22 p.m.)


Review request for mesos, Armand Grillet and Benjamin Bannier.


Summary (updated)
-----------------

Start from merge-base when posting reviews.


Repository: mesos


Description (updated)
-------

When posting a review originally created from a branch B, it could happen that the resulting
review included garbage changes if B was updated between revisions. (i.e., pulling new master
changes)

This review changes the logic of the `post-reviews.py` script to only include the changes
between `HEAD` and the merge base of the tracking branch into the review.


Diffs (updated)
-----

  support/post-reviews.py 94b43253f25044a79009010e92363d1536c74299 


Diff: https://reviews.apache.org/r/65545/diff/2/

Changes: https://reviews.apache.org/r/65545/diff/1-2/


Testing
-------


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message