mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 65545: Add warning in support/post-reviews.py.
Date Wed, 07 Feb 2018 14:35:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65545/#review196990
-----------------------------------------------------------




support/post-reviews.py
Lines 202 (patched)
<https://reviews.apache.org/r/65545/#comment277033>

    I'm tempted to make this fatal, since I cannot imagine a good reason why anyone would
want to still post the review, but I wanted to ask for other opinions first.


- Benno Evers


On Feb. 7, 2018, 2:33 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65545/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2018, 2:33 p.m.)
> 
> 
> Review request for mesos, Armand Grillet and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The new check warns developers if the specified tracking
> branch is not fast-forwardable to HEAD. The most likely
> cause of this condition is pulling a new version of the `master`
> branch and forgetting to rebase the review before calling
> the `post-reviews.py` script.
> 
> 
> Diffs
> -----
> 
>   support/post-reviews.py 94b43253f25044a79009010e92363d1536c74299 
> 
> 
> Diff: https://reviews.apache.org/r/65545/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message