mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gaston Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 65522: Fixed some log messages in `slave.cpp`.
Date Tue, 06 Feb 2018 18:29:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65522/#review196906
-----------------------------------------------------------


Fix it, then Ship it!




I noticed a minor inconsistency in `taskOrTaskGroup` that we might want to address in a different
patch.


src/slave/slave.cpp
Line 2091 (original), 2091 (patched)
<https://reviews.apache.org/r/65522/#comment276898>

    nit: s/was killed partially/was partially killed/ here and below.



src/slave/slave.cpp
Line 9530 (original), 9529 (patched)
<https://reviews.apache.org/r/65522/#comment276899>

    I noticed that if a single task is passed, we surround its ID in single quotes, but we
don't do that if a task groups is passed.
    
    We might want to do this consistently.


- Gaston Kleiman


On Feb. 5, 2018, 8:17 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65522/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2018, 8:17 p.m.)
> 
> 
> Review request for mesos, Gaston Kleiman and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed some log messages in `slave.cpp`.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp a6a5c93ab2d541c870cb52587495de20ed5ac1f4 
> 
> 
> Diff: https://reviews.apache.org/r/65522/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message