mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'.
Date Tue, 06 Feb 2018 17:40:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65461/
-----------------------------------------------------------

(Updated Feb. 6, 2018, 5:40 p.m.)


Review request for mesos, Alexander Rukletsov and Benjamin Mahler.


Repository: mesos


Description
-------

Provide new overload of 'ProcessBase::route()'.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/logging.hpp f9997677d69d54f5723d4fc0a495008d3ce11cc5

  3rdparty/libprocess/include/process/process.hpp 8661706cb058efb26f5bfbcc84972f9930d3670f

  3rdparty/libprocess/include/process/profiler.hpp 2991dd2033d68802a813de91babb47679c807aa0

  3rdparty/libprocess/src/metrics/metrics.cpp f79541853b4c826014ee969633345c3d51520ecf 


Diff: https://reviews.apache.org/r/65461/diff/2/

Changes: https://reviews.apache.org/r/65461/diff/1-2/


Testing
-------

It is a common pattern in libprocess to have a single function serving as endpoint that handles
both authenticated and non-authenticated requests, providing `None()` as a default parameter
in non-authenticated contexts.

This patch adds an overload to `ProcessBase::route()` implementing that so that it does not
need to be re-implemented in each individual process.


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message