mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Review Request 65518: Reaped the container process directly in Docker executor.
Date Tue, 06 Feb 2018 02:54:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65518/
-----------------------------------------------------------

Review request for mesos, Greg Mann and Vinod Kone.


Bugs: MESOS-8488
    https://issues.apache.org/jira/browse/MESOS-8488


Repository: mesos


Description
-------

Due to a Docker issue (https://github.com/moby/moby/issues/33820),
Docker daemon will fail to catch a container exit, i.e., the container
process has already exited but the command `docker ps` shows the
container still running, this will lead to the "docker run" command
that we execute in Docker executor never returns, and it will also
cause the `docker stop` command takes no effect, i.e., it will return
without error but `docker ps` shows the container still running, so
the task will stuck in `TASK_KILLING` state.

To workaround this Docker issue, in this patch we made Docker executor
reaps the container process directly so Docker executor will be notified
once the container process exits.


Diffs
-----

  src/docker/executor.cpp e4c53d558e414e50b1c429fba8e31e504c63744a 


Diff: https://reviews.apache.org/r/65518/diff/1/


Testing
-------

sudo make check


Thanks,

Qian Zhang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message