-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65506/#review196816
-----------------------------------------------------------
This looks like a no-op..? Defer is a dispatch functor, so it looks equivalent to your dispatch
functor.
- Benjamin Mahler
On Feb. 5, 2018, 5:46 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65506/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2018, 5:46 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Jie Yu.
>
>
> Bugs: MESOS-8524
> https://issues.apache.org/jira/browse/MESOS-8524
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch modifies the callbacks passed to the allocator to make sure
> they are dispatched instead of deferred. This is done to make sure
> that if another request potentially changing allocator state arrives
> after the allocator has invoked the callback, the callback is
> processed first. Otherwise we risk running into races on allocator
> state.
>
>
> Diffs
> -----
>
> src/master/master.cpp cc2685a6bc14103c639ce776cf1c912361e93381
>
>
> Diff: https://reviews.apache.org/r/65506/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
|