mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 65439: Made cleanliness checks in post-reviews.py less strict.
Date Mon, 05 Feb 2018 11:22:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65439/#review196804
-----------------------------------------------------------


Fix it, then Ship it!




I'll fix the style nits while committing.


support/post-reviews.py
Line 115 (original), 115 (patched)
<https://reviews.apache.org/r/65439/#comment276642>

    Let's at a line break after `sys.stderr`.



support/post-reviews.py
Line 122 (original), 122 (patched)
<https://reviews.apache.org/r/65439/#comment276643>

    Let's at a line break after `sys.stderr`.


- Benjamin Bannier


On Feb. 1, 2018, 3:07 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65439/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2018, 3:07 p.m.)
> 
> 
> Review request for mesos, Armand Grillet and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These checks generate a high amount of unnecessary work for developers
> who want to submit part of an ongoing refactoring for review, and
> since most developers are advanced git users anyways the amount of
> hand-holding seems unnecessary.
> 
> 
> Diffs
> -----
> 
>   support/post-reviews.py 231a3ac641d1ddf2f1788829f4fa8c36811bed90 
> 
> 
> Diff: https://reviews.apache.org/r/65439/diff/2/
> 
> 
> Testing
> -------
> 
> Posted this review with an unclean worktree (using python 2.7.14)
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message