mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 65396: Moved docker command check code inside health check library.
Date Fri, 02 Feb 2018 21:38:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65396/#review196732
-----------------------------------------------------------




src/checks/checker_process.cpp
Lines 523-525 (patched)
<https://reviews.apache.org/r/65396/#comment276555>

    It's kind of funny they're quoting this. Not something to fix here, but it's weird to
have hard-coded `sh -c`.
    
    Joe and I have talked about making the shell switchable (so you can switch between cmd.exe
and PowerShell on Windows, or sh and bash etc. on Linux). Maybe we should file an issue so
can start tracking hard-coded shells with a `TODO`?



src/checks/checker_process.cpp
Lines 529 (patched)
<https://reviews.apache.org/r/65396/#comment276558>

    Is `command.arguments()` iterable? If so, we could use the vector's reange constructor.


- Andrew Schwartzmeyer


On Jan. 29, 2018, 10:21 a.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65396/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2018, 10:21 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and Gaston Kleiman.
> 
> 
> Bugs: MESOS-8498
>     https://issues.apache.org/jira/browse/MESOS-8498
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Now with the health check library refactor, the wrapping of `docker
> exec` for docker command health checks can be easily moved inside
> the library.
> 
> 
> Diffs
> -----
> 
>   src/checks/checker_process.cpp ddb197b8cc2c503fef5ae20af32f5881fff9833f 
>   src/docker/executor.cpp e4c53d558e414e50b1c429fba8e31e504c63744a 
> 
> 
> Diff: https://reviews.apache.org/r/65396/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message