mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Review Request 65482: Fixed allocator bookkeeping of pending operations on master failover.
Date Fri, 02 Feb 2018 14:07:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65482/
-----------------------------------------------------------

Review request for mesos, Jie Yu and Jan Schlicht.


Bugs: MESOS-8536
    https://issues.apache.org/jira/browse/MESOS-8536


Repository: mesos


Description
-------

This patch fixes a bug where pending operations on a resource provider
resources where not properly accounted for in the allocator. This lead
to assertion failures when the operation became terminal and we
attempted to recover the used resources.

Since framework information is only remembered on agents if the
framework launched a task, there exists the possibility that a master
learns about an allocation to a framework unknown to it, yet. To
accommodate that do not bookkeep allocations to unknown frameworks in
the allocator and update code handling of terminal operation updates
accordingly.


Diffs
-----

  src/master/allocator/mesos/hierarchical.cpp f33ff767dcb93556beb696c96f8cfc17baccb05e 
  src/master/master.cpp cc2685a6bc14103c639ce776cf1c912361e93381 


Diff: https://reviews.apache.org/r/65482/diff/1/


Testing
-------

`make check`, also tested with a version of the test added in r/65045 which triggered this
issue.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message