mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 65060: Cleaned up endpoint directories after SLRP tests.
Date Fri, 02 Feb 2018 05:25:41 GMT


> On Jan. 19, 2018, 11:30 p.m., Greg Mann wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Lines 210-233 (patched)
> > <https://reviews.apache.org/r/65060/diff/1/?file=1938029#file1938029line210>
> >
> >     As we discussed offline, it would be great if we can move this into the test
fixture's `TearDown()` method.

Instead of handling this in `TearDown()`, I move this to `cluster::Slave::~Slave()`, since
the clean-up depends on the agent's work dir.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65060/#review195860
-----------------------------------------------------------


On Jan. 10, 2018, 2:37 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65060/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2018, 2:37 a.m.)
> 
> 
> Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
> 
> 
> Bugs: MESOS-8427
>     https://issues.apache.org/jira/browse/MESOS-8427
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Cleaned up endpoint directories after SLRP tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp 5ac91802e7c79e769c59c8418502ccc9d41f51b4

> 
> 
> Diff: https://reviews.apache.org/r/65060/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message