mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 65445: Added new protobuf field `launch_executor` in RunTask(Group)Message.
Date Thu, 01 Feb 2018 18:08:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65445/#review196610
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/slave.hpp
Lines 149 (patched)
<https://reviews.apache.org/r/65445/#comment276300>

    `s/runTaskMessageHandler/handleRunTaskMessage/`, so the name is consistent with `handleResourceProviderMessage`.



src/slave/slave.hpp
Lines 182 (patched)
<https://reviews.apache.org/r/65445/#comment276301>

    `s/runTaskGroupMessageHandler/handleRunTaskGroupMessage/`


- Chun-Hung Hsiao


On Feb. 1, 2018, 2 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65445/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2018, 2 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Vinod Kone.
> 
> 
> Bugs: MESOS-1720
>     https://issues.apache.org/jira/browse/MESOS-1720
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This boolean flag is used for the master to specify whether a
> new executor should be launched for the task or taskGroup (with
> the exception of command executor). This will let the master
> to control executor creation on the agent.
> 
> Also updated the relevant message handlers and mock functions.
> 
> 
> Diffs
> -----
> 
>   src/messages/messages.proto 0db44a24979cfdc748cd7fa3acd9e0346b14cfd3 
>   src/slave/slave.hpp 09c01ebd1b5e8008ba9e7d412042f1db76a2c5a5 
>   src/slave/slave.cpp a6a5c93ab2d541c870cb52587495de20ed5ac1f4 
>   src/tests/mock_slave.hpp 29ce7140501888d95d5f2d6c26b752ad276b484a 
>   src/tests/mock_slave.cpp 8357edc7b3a35624c813eccb9ecca9d3b5dbe07c 
>   src/tests/slave_tests.cpp f393a8433a984267adc4db307ef07fcbafd1e62f 
> 
> 
> Diff: https://reviews.apache.org/r/65445/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message