mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 65439: Made cleanliness checks in post-reviews.py less strict.
Date Thu, 01 Feb 2018 13:04:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65439/#review196631
-----------------------------------------------------------




support/post-reviews.py
Line 115 (original), 115 (patched)
<https://reviews.apache.org/r/65439/#comment276339>

    How about we call out that we continue despite the found issues, e.g.,
    
        WARNING: Worktree contains unstaged changes, continuing anyway.
        
    Maybe also print this to stderr instead of stdout.



support/post-reviews.py
Line 122 (original), 121 (patched)
<https://reviews.apache.org/r/65439/#comment276340>

    Ditto.


- Benjamin Bannier


On Jan. 31, 2018, 7:15 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65439/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2018, 7:15 p.m.)
> 
> 
> Review request for mesos and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These checks generate a high amount of unnecessary work for developers
> who want to submit part of an ongoing refactoring for review, and
> since most developers are advanced git users anyways the amount of
> hand-holding seems unnecessary.
> 
> 
> Diffs
> -----
> 
>   support/post-reviews.py 231a3ac641d1ddf2f1788829f4fa8c36811bed90 
> 
> 
> Diff: https://reviews.apache.org/r/65439/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message