From reviews-return-72190-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Jan 19 20:48:33 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DEE4217386 for ; Fri, 19 Jan 2018 20:48:33 +0000 (UTC) Received: (qmail 32459 invoked by uid 500); 19 Jan 2018 20:48:33 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 32415 invoked by uid 500); 19 Jan 2018 20:48:33 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 32403 invoked by uid 99); 19 Jan 2018 20:48:33 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Jan 2018 20:48:33 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 1F71718086C; Fri, 19 Jan 2018 20:48:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.99 X-Spam-Level: *** X-Spam-Status: No, score=3.99 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_LOW=-0.7, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id MEGSwMJxL6cM; Fri, 19 Jan 2018 20:48:31 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 212C45F343; Fri, 19 Jan 2018 20:48:31 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 78675E0373; Fri, 19 Jan 2018 20:48:30 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 7FC52C405CC; Fri, 19 Jan 2018 20:48:28 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4998581058021169552==" MIME-Version: 1.0 Subject: Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI. From: Eric Chung To: Armand Grillet , Kevin Klues , Jason Lai Cc: Mesos Reviewbot , Mesos Reviewbot Windows , mesos , Eric Chung Date: Fri, 19 Jan 2018 20:48:27 -0000 Message-ID: <20180119204827.64895.43000@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Eric Chung X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/61172/ X-Sender: Eric Chung References: <20180118042506.61229.93571@reviews-vm2.apache.org> In-Reply-To: <20180118042506.61229.93571@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: src/python/lib/tests/test_exceptions.py X-ReviewBoard-Diff-For: src/python/lib/tests/conftest.py X-ReviewBoard-Diff-For: src/python/lib/mesos/exceptions.py X-ReviewBoard-Diff-For: src/python/lib/mesos/http.py X-ReviewBoard-Diff-For: src/python/lib/tests/test_http.py Reply-To: Eric Chung X-ReviewRequest-Repository: mesos --===============4998581058021169552== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/ ----------------------------------------------------------- (Updated Jan. 19, 2018, 8:48 p.m.) Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues. Repository: mesos Description (updated) ------- Added mesos.http and mesos.exceptions for CLI. Part of MESOS-7310, this patch adds the mesos.http and mesos.exceptions modules, which provides a Resource class and its descendants for abstracting away common operations over http connectioins with JSON serialization. updated patch according to klueska's recommendations Diffs (updated) ----- src/python/cli_new/bootstrap c84e549e59bc7a07b5b70c24c63bc0c16881e442 src/python/lib/mesos/exceptions.py PRE-CREATION src/python/lib/mesos/http.py PRE-CREATION src/python/lib/requirements.in e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 src/python/lib/tests/conftest.py PRE-CREATION src/python/lib/tests/test_exceptions.py PRE-CREATION src/python/lib/tests/test_http.py PRE-CREATION src/python/lib/tox.ini 8ad030d2dbf1fb7a04f1eaadb587462b4ef3f054 support/pylint.config f74f553e238553bd6a6c06f4dd888cc5954a33eb Diff: https://reviews.apache.org/r/61172/diff/10/ Changes: https://reviews.apache.org/r/61172/diff/9-10/ Testing ------- install tox cd src/python/lib tox Thanks, Eric Chung --===============4998581058021169552==--