From reviews-return-72184-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Jan 19 13:37:24 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DBBD517B26 for ; Fri, 19 Jan 2018 13:37:24 +0000 (UTC) Received: (qmail 93502 invoked by uid 500); 19 Jan 2018 13:37:24 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 93462 invoked by uid 500); 19 Jan 2018 13:37:24 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 93451 invoked by uid 99); 19 Jan 2018 13:37:24 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Jan 2018 13:37:24 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 0EDA71A0D2C; Fri, 19 Jan 2018 13:37:24 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.79 X-Spam-Level: ** X-Spam-Status: No, score=2.79 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_LOW=-0.7, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id HlWrHQwb8ALd; Fri, 19 Jan 2018 13:37:22 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 860A45F23E; Fri, 19 Jan 2018 13:37:22 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1F567E0DB2; Fri, 19 Jan 2018 13:37:22 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 348DDC405CC; Fri, 19 Jan 2018 13:37:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1435180521845413245==" MIME-Version: 1.0 Subject: Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent. From: Jan Schlicht To: Benjamin Bannier , Jie Yu , Gaston Kleiman , Greg Mann Cc: Jan Schlicht , mesos Date: Fri, 19 Jan 2018 13:37:19 -0000 Message-ID: <20180119133719.64895.19166@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jan Schlicht X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65044/ X-Sender: Jan Schlicht References: <20180118141001.60649.26298@reviews-vm2.apache.org> In-Reply-To: <20180118141001.60649.26298@reviews-vm2.apache.org> Reply-To: Jan Schlicht X-ReviewRequest-Repository: mesos --===============1435180521845413245== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/ ----------------------------------------------------------- (Updated Jan. 19, 2018, 2:37 p.m.) Review request for mesos, Benjamin Bannier, Gaston Kleiman, Greg Mann, and Jie Yu. Changes ------- Addressed issues. Bugs: MESOS-8424 https://issues.apache.org/jira/browse/MESOS-8424 Repository: mesos Description ------- The 'GET_OPERATIONS' call lists all operations known to master or agent. Diffs (updated) ----- include/mesos/agent/agent.proto 315820041990d28e5cdae71c8385d4551d56558c include/mesos/master/master.proto 3e34634f3b864222d07374936c0d9a18269c2fbd include/mesos/v1/agent/agent.proto 9e8b49defb83ffd4dd240ebb3a09b2dd3610ab2a include/mesos/v1/master/master.proto 6759c3004e7e04c0044360b0c54f4438c2f6ec8a src/master/http.cpp c489b6f525f157811549b2cc84addd9d85e87990 src/master/master.hpp 05136781b6b1539f37c283e8127e4bafb187a0d1 src/master/validation.cpp f0b86775b7919ba6aa4a73038edb78a0adca68f4 src/slave/http.hpp 1619bb77e3e7d5a6d387e4d4bb071d83ce914967 src/slave/http.cpp 77e711ceeb0e2613d629b5e21fd686f85dfad11a src/slave/validation.cpp 0c2ccda177734cf3c47c0346ed34d20d58e7d932 src/tests/api_tests.cpp bdacc30be4dc8656a41a0c47d0e350d48e59ad94 Diff: https://reviews.apache.org/r/65044/diff/4/ Changes: https://reviews.apache.org/r/65044/diff/3-4/ Testing ------- make check Thanks, Jan Schlicht --===============1435180521845413245==--