From reviews-return-72172-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Jan 19 02:24:45 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 266A2102F3 for ; Fri, 19 Jan 2018 02:24:45 +0000 (UTC) Received: (qmail 86859 invoked by uid 500); 19 Jan 2018 02:24:45 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 86824 invoked by uid 500); 19 Jan 2018 02:24:45 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 86813 invoked by uid 99); 19 Jan 2018 02:24:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Jan 2018 02:24:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 4F49A18086F; Fri, 19 Jan 2018 02:24:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.539 X-Spam-Level: ** X-Spam-Status: No, score=2.539 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_LOW=-0.7, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 6gIZuqD-H-dA; Fri, 19 Jan 2018 02:24:43 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 8A54A5F47F; Fri, 19 Jan 2018 02:24:42 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D09A4E00A3; Fri, 19 Jan 2018 02:24:41 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 3EE77C405CC; Fri, 19 Jan 2018 02:24:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1219370020146171315==" MIME-Version: 1.0 Subject: Re: Review Request 65231: Fixed detaching task volume directories of destroyed frameworks. From: Chun-Hung Hsiao To: Qian Zhang , Michael Park , Vinod Kone Cc: Chun-Hung Hsiao , mesos Date: Fri, 19 Jan 2018 02:24:39 -0000 Message-ID: <20180119022439.60649.72228@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Chun-Hung Hsiao X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65231/ X-Sender: Chun-Hung Hsiao References: <20180119013653.60649.7871@reviews-vm2.apache.org> In-Reply-To: <20180119013653.60649.7871@reviews-vm2.apache.org> Reply-To: Chun-Hung Hsiao X-ReviewRequest-Repository: mesos --===============1219370020146171315== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Jan. 19, 2018, 1:36 a.m., Vinod Kone wrote: > > Can you or @qian write a unit test that triggered this bug? Let's do the unit test in another patch. Tracking with MESOS-8462. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65231/#review195764 ----------------------------------------------------------- On Jan. 19, 2018, 2:22 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65231/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2018, 2:22 a.m.) > > > Review request for mesos, Michael Park, Qian Zhang, and Vinod Kone. > > > Bugs: MESOS-8460 > https://issues.apache.org/jira/browse/MESOS-8460 > > > Repository: mesos > > > Description > ------- > > Fixed detaching task volume directories of destroyed frameworks. > > > Diffs > ----- > > src/slave/slave.hpp a07f046c7ed980bed3e3d0d2780295727b87ee44 > src/slave/slave.cpp 1672c06894c25e7120bb8a1da15f7d6432eb5954 > > > Diff: https://reviews.apache.org/r/65231/diff/4/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > > --===============1219370020146171315==--