From reviews-return-72161-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Jan 19 00:42:52 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 39F7417ED6 for ; Fri, 19 Jan 2018 00:42:52 +0000 (UTC) Received: (qmail 28914 invoked by uid 500); 19 Jan 2018 00:42:52 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 28873 invoked by uid 500); 19 Jan 2018 00:42:52 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 28862 invoked by uid 99); 19 Jan 2018 00:42:51 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Jan 2018 00:42:51 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 6D72C18079F; Fri, 19 Jan 2018 00:42:51 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.539 X-Spam-Level: ** X-Spam-Status: No, score=2.539 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_LOW=-0.7, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id wQpWaxZTnGXd; Fri, 19 Jan 2018 00:42:50 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E275C5F243; Fri, 19 Jan 2018 00:42:49 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7AF58E0383; Fri, 19 Jan 2018 00:42:49 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 50E26C405CC; Fri, 19 Jan 2018 00:42:49 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2724680568881289491==" MIME-Version: 1.0 Subject: Re: Review Request 65232: Resumed the clock if necessary when destroying test agent. From: Gaston Kleiman To: Benjamin Bannier , Gaston Kleiman Cc: Greg Mann , mesos Date: Fri, 19 Jan 2018 00:42:49 -0000 Message-ID: <20180119004249.60722.31562@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Gaston Kleiman X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65232/ X-Sender: Gaston Kleiman X-ReviewBoard-ShipIt: 1 References: <20180119004013.60649.38894@reviews-vm2.apache.org> In-Reply-To: <20180119004013.60649.38894@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Gaston Kleiman X-ReviewRequest-Repository: mesos --===============2724680568881289491== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65232/#review195760 ----------------------------------------------------------- Ship it! Ship It! - Gaston Kleiman On Jan. 18, 2018, 4:40 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65232/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2018, 4:40 p.m.) > > > Review request for mesos, Benjamin Bannier and Gaston Kleiman. > > > Repository: mesos > > > Description > ------- > > Because the `cgroups::destroy()` code path makes use of `delay()`, > the clock must not be paused in order for the destructor of the > test `Slave` to reliably destroy all remaining containers. > > This patch updates the destructor to check if the clock is paused > and, if so, resume it before destroying containers. > > > Diffs > ----- > > src/tests/cluster.cpp 568c9c7eda9d69e85bc32ce3259548b348ed9f25 > > > Diff: https://reviews.apache.org/r/65232/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Greg Mann > > --===============2724680568881289491==--