From reviews-return-72148-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Jan 18 19:31:01 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 64B7017EB6 for ; Thu, 18 Jan 2018 19:31:01 +0000 (UTC) Received: (qmail 96382 invoked by uid 500); 18 Jan 2018 19:31:01 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 96345 invoked by uid 500); 18 Jan 2018 19:31:01 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 96319 invoked by uid 99); 18 Jan 2018 19:31:00 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Jan 2018 19:31:00 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 6C74118058C; Thu, 18 Jan 2018 19:31:00 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.539 X-Spam-Level: ** X-Spam-Status: No, score=2.539 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_LOW=-0.7, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id G7vJn8RKwT7b; Thu, 18 Jan 2018 19:30:59 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 5E2EA5F47F; Thu, 18 Jan 2018 19:30:57 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B492DE00A3; Thu, 18 Jan 2018 19:30:56 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id D227AC40331; Thu, 18 Jan 2018 19:30:54 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2232758043346870408==" MIME-Version: 1.0 Subject: Re: Review Request 65059: Speeded up SLRP unit tests. From: Chun-Hung Hsiao To: Jie Yu , Gaston Kleiman , Greg Mann Cc: Chun-Hung Hsiao , mesos Date: Thu, 18 Jan 2018 19:30:53 -0000 Message-ID: <20180118193053.60650.96446@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Chun-Hung Hsiao X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65059/ X-Sender: Chun-Hung Hsiao References: <20180110023206.57200.51396@reviews-vm2.apache.org> In-Reply-To: <20180110023206.57200.51396@reviews-vm2.apache.org> Reply-To: Chun-Hung Hsiao X-ReviewRequest-Repository: mesos --===============2232758043346870408== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65059/ ----------------------------------------------------------- (Updated Jan. 18, 2018, 7:30 p.m.) Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu. Changes ------- Made changes for style consistency. Bugs: MESOS-8426 https://issues.apache.org/jira/browse/MESOS-8426 Repository: mesos Description ------- This patch makes all SLRP unit tests to use an allocation interval of 50ms and decline offers with filters. Diffs (updated) ----- src/tests/storage_local_resource_provider_tests.cpp bbfe95e9818f25fdd5405db3ad2fe355e023f743 Diff: https://reviews.apache.org/r/65059/diff/2/ Changes: https://reviews.apache.org/r/65059/diff/1-2/ Testing ------- sudo make check Thanks, Chun-Hung Hsiao --===============2232758043346870408==--