From reviews-return-72144-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Jan 18 18:49:05 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CEE3B17C5D for ; Thu, 18 Jan 2018 18:49:05 +0000 (UTC) Received: (qmail 90972 invoked by uid 500); 18 Jan 2018 18:49:05 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 90934 invoked by uid 500); 18 Jan 2018 18:49:05 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 90922 invoked by uid 99); 18 Jan 2018 18:49:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Jan 2018 18:49:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id EFCC11807B8; Thu, 18 Jan 2018 18:49:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.539 X-Spam-Level: ** X-Spam-Status: No, score=2.539 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_LOW=-0.7, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id NukrA8lyWOiK; Thu, 18 Jan 2018 18:49:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id CA6B75F27E; Thu, 18 Jan 2018 18:49:02 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 71609E00A3; Thu, 18 Jan 2018 18:49:02 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 840AFC40331; Thu, 18 Jan 2018 18:49:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0013422253455117529==" MIME-Version: 1.0 Subject: Re: Review Request 65032: Added a SLRP unit test for agent reboot. From: Greg Mann To: Jie Yu , Gaston Kleiman , Greg Mann Cc: Chun-Hung Hsiao , mesos Date: Thu, 18 Jan 2018 18:48:59 -0000 Message-ID: <20180118184859.60649.30016@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Greg Mann X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65032/ X-Sender: Greg Mann References: <20180110023622.57200.29658@reviews-vm2.apache.org> In-Reply-To: <20180110023622.57200.29658@reviews-vm2.apache.org> Reply-To: Greg Mann X-ReviewRequest-Repository: mesos --===============0013422253455117529== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65032/#review195643 ----------------------------------------------------------- src/tests/storage_local_resource_provider_tests.cpp Lines 1697 (patched) s/agentFlags/slaveFlags/g Or, let's just follow up at the end of the chain with a patch. I'm fine either way. src/tests/storage_local_resource_provider_tests.cpp Lines 1703-1711 (patched) Ditto here as in parent review - I think we can make this more concise? src/tests/storage_local_resource_provider_tests.cpp Lines 1749 (patched) I'm curious why you place all expectations together in some tests, and spread them throughout the test here and elsewhere? src/tests/storage_local_resource_provider_tests.cpp Lines 1753 (patched) s/agent/slave/ src/tests/storage_local_resource_provider_tests.cpp Lines 1759 (patched) s/volume/volumes/ src/tests/storage_local_resource_provider_tests.cpp Lines 1780-1781 (patched) Do we need the `.Times(Atleast(1))` here? I think we can rely on a single offer being rescinded when the agent is terminated? src/tests/storage_local_resource_provider_tests.cpp Lines 1867 (patched) Could we move the registering of this expectation out of this scope, and directly above the `StartSlave()` call below? - Greg Mann On Jan. 10, 2018, 2:36 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65032/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2018, 2:36 a.m.) > > > Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu. > > > Bugs: MESOS-8415 > https://issues.apache.org/jira/browse/MESOS-8415 > > > Repository: mesos > > > Description > ------- > > Added a SLRP unit test for agent reboot. > > > Diffs > ----- > > src/tests/storage_local_resource_provider_tests.cpp bbfe95e9818f25fdd5405db3ad2fe355e023f743 > > > Diff: https://reviews.apache.org/r/65032/diff/2/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > > --===============0013422253455117529==--