mesos-reviews mailing list archives: January 2018

Site index · List index
Message list« Previous · 1 · 2 · 3 · 4 · 5 · 6 · 7 · 8 · 9 · 10 · 11 · 12 · 13 · 14 · 15 · Next »Thread · Author · Date
Benjamin Mahler Review Request 65108: Added documentation for `protobuf::isTerminalState`. Fri, 12 Jan, 01:34
Benjamin Mahler Re: Review Request 65103: Updated quota documentation. Fri, 12 Jan, 01:39
Benjamin Mahler Re: Review Request 65063: Replace `stringify()` with `jsonify()` in http serialization. Fri, 12 Jan, 02:09
Benjamin Mahler Re: Review Request 65106: Removed the misleading `isRemovable` helper in the master. Fri, 12 Jan, 21:34
Benjamin Mahler Re: Review Request 64907: Added abandonment and process exit support to `loop()`. Sat, 13 Jan, 00:24
Benjamin Mahler Re: Review Request 64908: Refactored `HttpProxy` to not rely on `SocketManager`. Sat, 13 Jan, 01:38
Benjamin Mahler Re: Review Request 64909: Removed unnecessary `SocketManager::dispose` data structure. Sat, 13 Jan, 01:48
Benjamin Mahler Re: Review Request 61158: Introduced http::Server in process.cpp. Sat, 13 Jan, 02:21
Benjamin Mahler Review Request 65150: Added support for discarding a Future from Queue::get. Sat, 13 Jan, 21:35
Benjamin Mahler Review Request 65151: Added a test for discarding a future from Queue::get. Sat, 13 Jan, 21:35
Benjamin Mahler Re: Review Request 64073: Fixed ignored Socket::accept discard when using LibeventSSLSocketImpl. Sat, 13 Jan, 21:36
Benjamin Mahler Re: Review Request 64910: Used `loop`() for `SocketManager` socket sending. Sat, 13 Jan, 22:01
Benjamin Mahler Re: Review Request 64911: Refactored connection logic in libprocess. Sun, 14 Jan, 21:42
Benjamin Mahler Re: Review Request 61157: Refactored ProcessManager::handle for future use with http::Server. Mon, 15 Jan, 20:58
Benjamin Mahler Re: Review Request 64907: Added abandonment and process exit support to `loop()`. Mon, 15 Jan, 21:01
Benjamin Mahler Re: Review Request 64909: Removed unnecessary `SocketManager::dispose` data structure. Mon, 15 Jan, 21:01
Benjamin Mahler Re: Review Request 65171: Reduced copying of Response by adding extra override Headers. Mon, 15 Jan, 21:06
Benjamin Mahler Re: Review Request 65150: Added support for discarding a Future from Queue::get. Tue, 16 Jan, 21:40
Benjamin Mahler Review Request 65183: Fixed a libprocess finalization deadlock due to Queue discard support. Tue, 16 Jan, 21:41
Benjamin Mahler Re: Review Request 64969: Added an performance benchmark for master `Getstate` v1 api. Wed, 17 Jan, 01:38
Benjamin Mahler Re: Review Request 65114: Updated C++ Style Guide. Wed, 17 Jan, 03:20
Benjamin Mahler Review Request 65200: Added a default move constructor for Result. Wed, 17 Jan, 23:30
Benjamin Mahler Review Request 65204: Eliminated some unnecessary copying in the agent's HTTP operator API. Thu, 18 Jan, 01:19
Benjamin Mahler Re: Review Request 65253: Avoided dropping events on the master operator API stream. Mon, 22 Jan, 23:07
Benjamin Mahler Re: Review Request 65106: Removed the misleading `isRemovable` helper in the master. Tue, 23 Jan, 00:11
Benjamin Mahler Re: Review Request 65106: Removed the misleading `isRemovable` helper in the master. Tue, 23 Jan, 00:11
Benjamin Mahler Re: Review Request 65246: Added download button for master and agent logs in Web UI. Tue, 23 Jan, 00:34
Benjamin Mahler Re: Review Request 65277: Logged pid of launched containers in the linux launcher. Tue, 23 Jan, 02:10
Benjamin Mahler Re: Review Request 65111: Added tests to verify the executor is shutdown if no task is delivered. Tue, 23 Jan, 03:05
Benjamin Mahler Re: Review Request 65106: Removed the misleading `isRemovable` helper in the master. Tue, 23 Jan, 03:21
Benjamin Mahler Review Request 65305: Fixed a libprocess crash when tests clear the authorization callbacks. Wed, 24 Jan, 00:54
Benjamin Mahler Re: Review Request 64574: Ensured trailing '/' in URL is insignificant. Wed, 24 Jan, 01:25
Benjamin Mahler Re: Review Request 65305: Fixed a libprocess crash when tests clear the authorization callbacks. Wed, 24 Jan, 20:23
Benjamin Mahler Re: Review Request 65183: Fixed a libprocess finalization deadlock due to Queue discard support. Wed, 24 Jan, 23:21
Benjamin Mahler Review Request 65334: Added quota limit to the master API protos. Thu, 25 Jan, 02:45
Benjamin Mahler Re: Review Request 65223: Removed duplicated "/help" prefix in links in /help response. Thu, 25 Jan, 02:53
Benjamin Mahler Re: Review Request 65109: Fixed a bug relating to lingering executors. Sat, 27 Jan, 02:09
Benjamin Mahler Re: Review Request 65109: Fixed a bug relating to lingering executors. Sat, 27 Jan, 02:10
Benjamin Mahler Re: Review Request 65351: Reordered roles in Web UI to display them alphabetically by default. Sat, 27 Jan, 02:22
Benjamin Mahler Re: Review Request 65346: Updated Web UI to show quota guarantee and limit for roles. Sat, 27 Jan, 02:33
Benjamin Mahler Re: Review Request 65367: Added equality operator for Unavailability protobuf. Sat, 27 Jan, 02:53
Benjamin Mahler Review Request 65375: Added move construction and assignment to Future. Mon, 29 Jan, 02:29
Benjamin Mahler Re: Review Request 65366: Added test for maintenance-related offer rescinding behavior. Mon, 29 Jan, 05:01
Benjamin Mahler Re: Review Request 65368: Updated maintenance schedule logic. Mon, 29 Jan, 05:22
Benjamin Mahler Re: Review Request 65351: Reordered roles in Web UI to display them alphabetically by default. Mon, 29 Jan, 19:25
Benjamin Mahler Re: Review Request 65246: Added download button for master and agent logs in Web UI. Tue, 30 Jan, 00:01
Benjamin Mahler Re: Review Request 65111: Added tests to verify the executor is shutdown if no task is delivered. Tue, 30 Jan, 00:49
Benjamin Mahler Re: Review Request 65369: Added test to ensure v1 executor is shutdown upon initial task all-kill. Tue, 30 Jan, 23:10
Benjamin Mahler Re: Review Request 65334: Added quota limit to the master API protos. Wed, 31 Jan, 00:21
Benno Evers Re: Review Request 64889: Fixed handling of checkpointed resources for RP-capable agents. Tue, 02 Jan, 15:55
Benno Evers Re: Review Request 64891: Future-proofed use of agent capabilities in tests. Wed, 03 Jan, 11:37
Benno Evers Re: Review Request 64889: Fixed handling of checkpointed resources for RP-capable agents. Wed, 03 Jan, 11:38
Benno Evers Re: Review Request 64888: Added check for handling of checkpointed resources in reregistration. Wed, 03 Jan, 11:40
Benno Evers Review Request 65019: Added new reconfiguration_policy flag to docs/updgrades.md. Mon, 08 Jan, 13:52
Benno Evers Re: Review Request 64930: Unified the marking agent unreachable logic in the master. Mon, 08 Jan, 17:31
Benno Evers Re: Review Request 62161: Update boost version. Tue, 09 Jan, 17:18
Benno Evers Review Request 65074: Fixed comparison logic for additive reconfiguration policy. Wed, 10 Jan, 16:07
Benno Evers Re: Review Request 64930: Unified the marking agent unreachable logic in the master. Wed, 10 Jan, 17:54
Benno Evers Re: Review Request 64930: Unified the marking agent unreachable logic in the master. Wed, 10 Jan, 17:54
Benno Evers Re: Review Request 64931: Added a TODO for informing frameworks that an agent is unreachable. Wed, 10 Jan, 17:55
Benno Evers Re: Review Request 65074: Fixed comparison logic for additive reconfiguration policy. Fri, 12 Jan, 15:40
Benno Evers Re: Review Request 65074: Fixed comparison logic for additive reconfiguration policy. Fri, 12 Jan, 15:41
Benno Evers Re: Review Request 62160: Fixed stout build with newer boost versions. Wed, 17 Jan, 16:06
Benno Evers Re: Review Request 62444: Added UNREACHABLE() macro to __cxa_pure_virtual. Wed, 17 Jan, 16:07
Benno Evers Re: Review Request 62161: Updated boost version. Wed, 17 Jan, 16:09
Benno Evers Re: Review Request 62445: Removed duplicate block in configure.ac. Wed, 17 Jan, 16:10
Benno Evers Re: Review Request 62447: Reverted usage of `-isystem` flag. Wed, 17 Jan, 16:10
Benno Evers Re: Review Request 65215: Updated mesos-tidy setup for upgraded Boost version. Mon, 22 Jan, 13:53
Benno Evers Re: Review Request 63365: Re-ordered some configuration options alphabetically. Wed, 24 Jan, 13:58
Benno Evers Re: Review Request 64574: Ensured trailing '/' in URL is insignificant. Wed, 24 Jan, 14:24
Benno Evers Re: Review Request 64574: Ensured trailing '/' in URL is insignificant. Wed, 24 Jan, 14:25
Benno Evers Review Request 65308: WIP: Fix warnings in tests. Wed, 24 Jan, 14:57
Benno Evers Re: Review Request 62447: Reverted usage of the -isystem flag for includes (1/3). Wed, 24 Jan, 14:57
Benno Evers Re: Review Request 63367: Added overloads for strings::startsWith and strings::endsWith(). Wed, 24 Jan, 15:12
Benno Evers Re: Review Request 65308: Fix shadowed sign-compare and enum-compare warnings in tests. Wed, 24 Jan, 16:17
Benno Evers Re: Review Request 62447: Reverted usage of the -isystem flag for includes (1/3). Wed, 24 Jan, 16:18
Benno Evers Review Request 65289: Reverted usage of the -isystem flag for includes (2/3). Wed, 24 Jan, 16:23
Benno Evers Review Request 65290: Reverted usage of the -isystem flag for includes (3/3). Wed, 24 Jan, 16:23
Benno Evers Re: Review Request 63366: Added jemalloc release tarball and build rules. Wed, 24 Jan, 16:37
Benno Evers Review Request 65307: Cleaned up interface defintion in duration header. Wed, 24 Jan, 16:38
Benno Evers Re: Review Request 63372: Added documentation for memory profiling. Wed, 24 Jan, 16:40
Benno Evers Re: Review Request 63366: Added jemalloc release tarball and build rules. Wed, 24 Jan, 16:42
Benno Evers Re: Review Request 65322: Made `numify` less dependent on `boost::lexical_cast` failure behavior. Thu, 25 Jan, 13:18
Benno Evers Re: Review Request 65280: Fixed make clean without Python. Thu, 25 Jan, 13:31
Benno Evers Re: Review Request 63368: Added MemoryProfiler class to Libprocess. Thu, 25 Jan, 14:24
Benno Evers Re: Review Request 63368: Added MemoryProfiler class to Libprocess. Thu, 25 Jan, 14:49
Benno Evers Re: Review Request 63367: Added overloads for strings::startsWith and strings::endsWith(). Thu, 25 Jan, 17:41
Benno Evers Review Request 65347: Added missing protobuf include. Fri, 26 Jan, 11:41
Benno Evers Re: Review Request 63369: Added new '/state' and '/statistics' endpoints to the MemoryProfiler. Fri, 26 Jan, 14:18
Benno Evers Review Request 65354: Fix flakyness in MasterTest.RegistryGcByCount. Fri, 26 Jan, 18:12
Benno Evers Re: Review Request 65354: Fix flakyness in MasterTest.RegistryGcByCount. Fri, 26 Jan, 18:12
Benno Evers Re: Review Request 63368: Added MemoryProfiler class to Libprocess. Mon, 29 Jan, 10:54
Benno Evers Review Request 65437: Added documentation for fault domains. Wed, 31 Jan, 17:50
Benno Evers Review Request 65439: Made cleanliness checks in post-reviews.py less strict. Wed, 31 Jan, 17:51
Benno Evers Re: Review Request 65437: Added documentation for fault domains. Wed, 31 Jan, 18:04
Chun-Hung Hsiao Review Request 64897: Fixed CI build failure for `volume_profile.pb.h`. Tue, 02 Jan, 21:15
Chun-Hung Hsiao Review Request 64899: Removed `nodist_liburi_volume_profile_SOURCES`. Tue, 02 Jan, 22:48
Chun-Hung Hsiao Review Request 64901: Renamed ACL fields for standalone container API for consistency. Wed, 03 Jan, 00:49
Chun-Hung Hsiao Re: Review Request 64739: Upgraded resources that come from `protobuf::read`. Wed, 03 Jan, 19:20
Chun-Hung Hsiao Re: Review Request 64924: Fixed the broken GRPC build. Wed, 03 Jan, 20:02
Message list« Previous · 1 · 2 · 3 · 4 · 5 · 6 · 7 · 8 · 9 · 10 · 11 · 12 · 13 · 14 · 15 · Next »Thread · Author · Date
Box list
Oct 201963
Sep 2019312
Aug 2019540
Jul 2019707
Jun 2019621
May 2019472
Apr 2019702
Mar 2019955
Feb 2019758
Jan 2019749
Dec 2018455
Nov 2018598
Oct 2018832
Sep 2018704
Aug 20181218
Jul 20181040
Jun 20181026
May 20181520
Apr 20181445
Mar 20181350
Feb 20181396
Jan 20181470
Dec 20171464
Nov 20171769
Oct 20171445
Sep 20171054
Aug 20171341
Jul 20171295
Jun 20171475
May 20171547
Apr 20171266
Mar 20172102
Feb 20171631
Jan 20171655
Dec 20161774
Nov 20162300
Oct 20162196
Sep 20162748
Aug 20162311
Jul 20163001
Jun 20163216
May 20162928
Apr 20163332
Mar 20164025
Feb 20162997
Jan 20163700
Dec 20152431
Nov 20152744
Oct 20152284
Sep 20152621
Aug 20152300
Jul 20152051
Jun 20152449
May 20151444
Apr 2015338