mesos-reviews mailing list archives: January 2018

Site index · List index
Message list« Previous · 1 · 2 · 3 · 4 · 5 · 6 · 7 · 8 · 9 · 10 · 11 · 12 · 13 · 14 · 15 · Next »Thread · Author · Date
Benjamin Bannier Review Request 65093: Simplified master's `updateOperation` function. Thu, 11 Jan, 13:53
Benjamin Bannier Re: Review Request 65072: Fixed handling of terminal operations in updateSlave handler. Thu, 11 Jan, 13:53
Benjamin Bannier Re: Review Request 65072: Fixed handling of terminal operations in updateSlave handler. Thu, 11 Jan, 13:53
Benjamin Bannier Re: Review Request 65072: Fixed handling of terminal operations in updateSlave handler. Thu, 11 Jan, 15:59
Benjamin Bannier Re: Review Request 65096: Fixed master's `updateOperation` for operations without framework ID. Fri, 12 Jan, 10:53
Benjamin Bannier Re: Review Request 65095: Made it possible to update an operation without mutating resources. Fri, 12 Jan, 10:53
Benjamin Bannier Re: Review Request 65072: Fixed handling of terminal operations in `updateSlave` handler. Fri, 12 Jan, 10:57
Benjamin Bannier Re: Review Request 65072: Fixed handling of terminal operations in `updateSlave` handler. Fri, 12 Jan, 10:57
Benjamin Bannier Re: Review Request 65096: Fixed master's `updateOperation` for operations without framework ID. Fri, 12 Jan, 10:57
Benjamin Bannier Re: Review Request 65095: Made it possible to update an operation without mutating resources. Fri, 12 Jan, 10:58
Benjamin Bannier Re: Review Request 65096: Fixed master's `updateOperation` for operations without framework ID. Fri, 12 Jan, 12:49
Benjamin Bannier Re: Review Request 65149: MesosTidy: Enabled `mesos-this-capture`. Sat, 13 Jan, 07:27
Benjamin Bannier Review Request 65160: Removed some redundant `get` calls in stout. Mon, 15 Jan, 09:09
Benjamin Bannier Review Request 65161: Removed some redundant `get` calls in libprocess. Mon, 15 Jan, 09:09
Benjamin Bannier Review Request 65162: Removed some redundant `get` calls. Mon, 15 Jan, 09:09
Benjamin Bannier Re: Review Request 65125: Added a helper function for resource provider tests. Mon, 15 Jan, 09:57
Benjamin Bannier Re: Review Request 65126: Added a resource provider test case. Mon, 15 Jan, 09:57
Benjamin Bannier Re: Review Request 65045: Tested correct operation handling during master failover. Mon, 15 Jan, 10:34
Benjamin Bannier Re: Review Request 65045: Tested correct operation handling during master failover. Mon, 15 Jan, 10:58
Benjamin Bannier Review Request 65166: Added libprocess benchmarks to cmake build setup. Mon, 15 Jan, 11:48
Benjamin Bannier Re: Review Request 65039: Tested reconciliation when operation is dropped en route to agent. Wed, 17 Jan, 08:44
Benjamin Bannier Re: Review Request 65043: Moved agent response code into 'protobuf_utils.cpp'. Wed, 17 Jan, 08:59
Benjamin Bannier Re: Review Request 65044: Added the list of operations to the 'GET_AGENTS' response. Wed, 17 Jan, 09:18
Benjamin Bannier Re: Review Request 65126: Added a resource provider test case. Wed, 17 Jan, 11:15
Benjamin Bannier Re: Review Request 65126: Added a resource provider test case. Wed, 17 Jan, 11:18
Benjamin Bannier Re: Review Request 65045: Tested correct operation handling during master failover. Wed, 17 Jan, 11:18
Benjamin Bannier Re: Review Request 65125: Added a helper function for resource provider tests. Wed, 17 Jan, 11:27
Benjamin Bannier Re: Review Request 64823: Documented the change in the Protobuf requirement. Wed, 17 Jan, 11:31
Benjamin Bannier Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode. Wed, 17 Jan, 12:22
Benjamin Bannier Re: Review Request 65166: Added libprocess benchmarks to cmake build setup. Wed, 17 Jan, 20:42
Benjamin Bannier Re: Review Request 65166: Added libprocess benchmarks to cmake build setup. Wed, 17 Jan, 20:42
Benjamin Bannier Re: Review Request 65039: Tested reconciliation when operation is dropped en route to agent. Thu, 18 Jan, 09:23
Benjamin Bannier Re: Review Request 65166: Added libprocess benchmarks to cmake build setup. Thu, 18 Jan, 10:36
Benjamin Bannier Review Request 65208: Prevented redundant descriptions when applying reviewboard reviews. Thu, 18 Jan, 10:53
Benjamin Bannier Re: Review Request 65212: Updated `mesos-tidy` docker build setup for benchmarks. Thu, 18 Jan, 13:24
Benjamin Bannier Re: Review Request 65232: Resumed the clock if necessary when destroying test agent. Fri, 19 Jan, 17:03
Benjamin Bannier Review Request 65215: Updated mesos-tidy setup for upgraded Boost version. Mon, 22 Jan, 12:58
Benjamin Bannier Re: Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode. Mon, 22 Jan, 13:58
Benjamin Bannier Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent. Mon, 22 Jan, 18:37
Benjamin Bannier Re: Review Request 65045: Tested correct operation handling during master failover. Mon, 22 Jan, 18:58
Benjamin Bannier Re: Review Request 65201: Added a global `DEFAULT_TEST_TIMEOUT` variable. Mon, 22 Jan, 21:08
Benjamin Bannier Re: Review Request 65202: Adopted the libprocess `DEFAULT_TEST_TIMEOUT`. Mon, 22 Jan, 21:17
Benjamin Bannier Re: Review Request 62447: Reverted usage of `-isystem` flag. Tue, 23 Jan, 14:18
Benjamin Bannier Re: Review Request 65326: Fixed conversion warning. Wed, 24 Jan, 21:56
Benjamin Bannier Re: Review Request 65326: Fixed conversion warning. Wed, 24 Jan, 23:15
Benjamin Bannier Re: Review Request 65322: Made `numify` less dependent on `boost::lexical_cast` failure behavior. Thu, 25 Jan, 06:32
Benjamin Bannier Re: Review Request 65201: Added a global `DEFAULT_TEST_TIMEOUT` variable. Thu, 25 Jan, 07:28
Benjamin Bannier Re: Review Request 65202: Adopted the libprocess `DEFAULT_TEST_TIMEOUT`. Thu, 25 Jan, 07:48
Benjamin Bannier Re: Review Request 65298: Split test flags into header and source files. Thu, 25 Jan, 07:49
Benjamin Bannier Re: Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode. Thu, 25 Jan, 08:28
Benjamin Bannier Re: Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode. Thu, 25 Jan, 08:40
Benjamin Bannier Re: Review Request 65322: Made `numify` less dependent on `boost::lexical_cast` failure behavior. Thu, 25 Jan, 14:32
Benjamin Bannier Re: Review Request 65322: Made `numify` less dependent on `boost::lexical_cast` failure behavior. Thu, 25 Jan, 14:32
Benjamin Bannier Re: Review Request 65322: Made `numify` less dependent on `boost::lexical_cast` failure behavior. Thu, 25 Jan, 16:17
Benjamin Hindman Review Request 64906: Exposed `send()` helpers for `Socket`'s. Wed, 03 Jan, 07:19
Benjamin Hindman Review Request 64907: Added abandonment and process exit support to `loop()`. Wed, 03 Jan, 07:20
Benjamin Hindman Review Request 64908: Refactored `HttpProxy` to not rely on `SocketManager`. Wed, 03 Jan, 07:20
Benjamin Hindman Review Request 64909: Removed unnecessary `SocketManager::dispose` data structure. Wed, 03 Jan, 07:21
Benjamin Hindman Review Request 65171: Reduced copying of Response by adding extra override Headers. Mon, 15 Jan, 20:46
Benjamin Hindman Re: Review Request 65150: Added support for discarding a Future from Queue::get. Mon, 15 Jan, 20:52
Benjamin Hindman Re: Review Request 65151: Added a test for discarding a future from Queue::get. Mon, 15 Jan, 21:03
Benjamin Mahler Re: Review Request 64895: Renamed "normalize" to "upgrade" in resources adjustment operations. Tue, 02 Jan, 22:12
Benjamin Mahler Re: Review Request 64739: Upgraded resources that come from `protobuf::read`. Tue, 02 Jan, 22:39
Benjamin Mahler Re: Review Request 63977: Used the protobuf-reflection-based 'downgradeResources' utility. Tue, 02 Jan, 22:50
Benjamin Mahler Re: Review Request 64919: Updated the comment for `precomputeResourcesContainment`. Wed, 03 Jan, 21:00
Benjamin Mahler Re: Review Request 64920: Introduced `upgradeResources` to complement `downgradeResources`. Wed, 03 Jan, 21:04
Benjamin Mahler Review Request 64927: Updated the master to use .at for const access to `slaves.unreachable`. Wed, 03 Jan, 22:48
Benjamin Mahler Review Request 64928: Added CHECKs to prevent accidental overwrite of slaves.unreachable. Wed, 03 Jan, 22:48
Benjamin Mahler Review Request 64929: Documented a rate limiting bug in marking agents unreachable. Wed, 03 Jan, 22:48
Benjamin Mahler Review Request 64930: Unified the marking agent unreachable logic in the master. Wed, 03 Jan, 22:48
Benjamin Mahler Review Request 64931: Added a TODO for informing frameworks that an agent is unreachable. Wed, 03 Jan, 22:48
Benjamin Mahler Re: Review Request 64929: Documented a rate limiting bug in marking agents unreachable. Thu, 04 Jan, 01:07
Benjamin Mahler Review Request 64939: Abort libprocess when a Process throws an uncaught exception. Thu, 04 Jan, 01:30
Benjamin Mahler Review Request 64968: Removed the inaccurate `slaves.transitioning` function in the master. Fri, 05 Jan, 01:38
Benjamin Mahler Re: Review Request 64969: Added an performance benchmark for master `getstate` v1 api. Sat, 06 Jan, 00:40
Benjamin Mahler Re: Review Request 64969: Added an performance benchmark for master `getstate` v1 api. Sat, 06 Jan, 03:20
Benjamin Mahler Review Request 65011: Reverted back to alphabetical ordering of libprocess metrics in JSON. Mon, 08 Jan, 00:57
Benjamin Mahler Review Request 65012: Added tests to ensure that libprocess metrics are alphabetical. Mon, 08 Jan, 00:57
Benjamin Mahler Review Request 65013: Removed gtest thread safe filter in libprocess tests. Mon, 08 Jan, 00:57
Benjamin Mahler Re: Review Request 64930: Unified the marking agent unreachable logic in the master. Tue, 09 Jan, 08:06
Benjamin Mahler Re: Review Request 64930: Unified the marking agent unreachable logic in the master. Tue, 09 Jan, 08:06
Benjamin Mahler Re: Review Request 64969: Added an performance benchmark for master `getstate` v1 api. Tue, 09 Jan, 20:33
Benjamin Mahler Re: Review Request 65048: Logged socket create/connect failures on warning level. Tue, 09 Jan, 20:37
Benjamin Mahler Re: Review Request 65048: Logged socket create/connect failures on warning level. Tue, 09 Jan, 20:38
Benjamin Mahler Re: Review Request 65029: Added `vector<Resource>` overloads for `(down/up)gradeResources`. Wed, 10 Jan, 01:12
Benjamin Mahler Re: Review Request 65021: Returned `Try<T>` from `protobuf::read(path)` rather than `Result<T>`. Wed, 10 Jan, 01:14
Benjamin Mahler Re: Review Request 65023: Added `state::read` to complement `state::checkpoint`. Wed, 10 Jan, 01:19
Benjamin Mahler Re: Review Request 65024: Replaced `protobuf::read` with `state::read`. Wed, 10 Jan, 01:22
Benjamin Mahler Re: Review Request 65025: Replaced `os::read` with `state::read`. Wed, 10 Jan, 01:23
Benjamin Mahler Re: Review Request 65026: Replaced `ResourcesState::recoverResources` with `state::read`. Wed, 10 Jan, 01:29
Benjamin Mahler Re: Review Request 65030: Replaced `convertResourceFormat` with `upgradeResources` accordingly. Wed, 10 Jan, 01:43
Benjamin Mahler Re: Review Request 65031: Replaced `convertResourceFormat` with `downgradeResources` accordingly. Wed, 10 Jan, 01:47
Benjamin Mahler Re: Review Request 65022: Updated uses of `protobuf::read(path)` which now returns `Try<T>`. Wed, 10 Jan, 01:49
Benjamin Mahler Re: Review Request 65054: Fixed the order of parameters of `is_specialization_of` in stout. Wed, 10 Jan, 01:50
Benjamin Mahler Re: Review Request 65055: Fixed the order of parameters of `is_specialization_of` in libprocess. Wed, 10 Jan, 01:50
Benjamin Mahler Re: Review Request 64906: Exposed `send()` helpers for `Socket`'s. Wed, 10 Jan, 04:10
Benjamin Mahler Re: Review Request 64930: Unified the marking agent unreachable logic in the master. Wed, 10 Jan, 22:44
Benjamin Mahler Re: Review Request 65022: Updated uses of `protobuf::read(path)` which now returns `Try<T>`. Wed, 10 Jan, 22:51
Benjamin Mahler Review Request 65106: Removed the misleading `isRemovable` helper in the master. Fri, 12 Jan, 01:34
Benjamin Mahler Review Request 65107: Updated the task state metrics to be more readable. Fri, 12 Jan, 01:34
Message list« Previous · 1 · 2 · 3 · 4 · 5 · 6 · 7 · 8 · 9 · 10 · 11 · 12 · 13 · 14 · 15 · Next »Thread · Author · Date
Box list
Oct 201976
Sep 2019312
Aug 2019540
Jul 2019707
Jun 2019621
May 2019472
Apr 2019702
Mar 2019955
Feb 2019758
Jan 2019749
Dec 2018455
Nov 2018598
Oct 2018832
Sep 2018704
Aug 20181218
Jul 20181040
Jun 20181026
May 20181520
Apr 20181445
Mar 20181350
Feb 20181396
Jan 20181470
Dec 20171464
Nov 20171769
Oct 20171445
Sep 20171054
Aug 20171341
Jul 20171295
Jun 20171475
May 20171547
Apr 20171266
Mar 20172102
Feb 20171631
Jan 20171655
Dec 20161774
Nov 20162300
Oct 20162196
Sep 20162748
Aug 20162311
Jul 20163001
Jun 20163216
May 20162928
Apr 20163332
Mar 20164025
Feb 20162997
Jan 20163700
Dec 20152431
Nov 20152744
Oct 20152284
Sep 20152621
Aug 20152300
Jul 20152051
Jun 20152449
May 20151444
Apr 2015338