mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 65442: Made `ns::setns` overloads consistent.
Date Wed, 31 Jan 2018 21:25:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65442/#review196594
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Jan. 31, 2018, 9 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65442/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2018, 9 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Only the path-based overload of `ns::setns` accepted the
> `checkMultithreaded` flag. For API consistency, we now also
> accept this flag in the PID-based overload.
> 
> 
> Diffs
> -----
> 
>   src/linux/ns.hpp e24d79a41eefcade343b2825b5a758d7d30a5f91 
>   src/linux/ns.cpp 446640705b7c060776ed87655fb17509865cd335 
> 
> 
> Diff: https://reviews.apache.org/r/65442/diff/1/
> 
> 
> Testing
> -------
> 
> make check (Fedora 27)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message