mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 65426: Made gRPC calls wait for the channel to be ready.
Date Wed, 31 Jan 2018 19:10:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65426/#review196582
-----------------------------------------------------------


Ship it!




LGTM. Long term, let's expose those knobs to the caller and let caller decides

- Jie Yu


On Jan. 31, 2018, 12:59 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65426/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2018, 12:59 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Jie Yu.
> 
> 
> Bugs: MESOS-8514
>     https://issues.apache.org/jira/browse/MESOS-8514
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> It takes long in gRPC 1.8 to prepare a domain socket, and as a result,
> SLRP cannot talk to a CSI plugin immediately after the socket file is
> created. This patch fixes this problem by asking gRPC calls to wait for
> the socket to be ready.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/grpc.hpp 0f63e576f04af4df8894626eebbb1a0e01eadf22

> 
> 
> Diff: https://reviews.apache.org/r/65426/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message