mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 65369: Added test to ensure v1 executor is shutdown upon initial task all-kill.
Date Tue, 30 Jan 2018 23:10:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65369/#review196539
-----------------------------------------------------------



Looks good, I will wait to push the chain until there's also the failover case tested for
v1. Did we want to test LAUNCH and LAUNCH group or is the logic sufficiently similar?


src/tests/slave_tests.cpp
Lines 4767-4769 (patched)
<https://reviews.apache.org/r/65369/#comment276226>

    I filed a ticket, consider referencing it here: MESOS-8511
    
    E.g.
    
    ```
    This test could be simplified if we had a test scheduler that provides some basic task
launching functionality (see MESOS-8511).
    ```



src/tests/slave_tests.cpp
Lines 4767-4769 (patched)
<https://reviews.apache.org/r/65369/#comment276229>

    This only tests the task group case, can you document that here? Do we also want to test
the non-group LAUNCH case?



src/tests/slave_tests.cpp
Lines 4792-4793 (patched)
<https://reviews.apache.org/r/65369/#comment276225>

    Do you need this?



src/tests/slave_tests.cpp
Lines 4827-4835 (patched)
<https://reviews.apache.org/r/65369/#comment276227>

    There's a createCallSusbscribe, can you use that here?



src/tests/slave_tests.cpp
Lines 4886-4904 (patched)
<https://reviews.apache.org/r/65369/#comment276228>

    There's a createCallAccept, can you use that here?



src/tests/slave_tests.cpp
Lines 4934-4935 (patched)
<https://reviews.apache.org/r/65369/#comment276231>

    Can you clarify that we kill only 1 of the tasks and expect the entire task group to be
killed?



src/tests/slave_tests.cpp
Lines 4934-4935 (patched)
<https://reviews.apache.org/r/65369/#comment276232>

    Can you clarify that we kill only 1 of the tasks and expect the entire task group to be
killed?



src/tests/slave_tests.cpp
Lines 4934-4935 (patched)
<https://reviews.apache.org/r/65369/#comment276233>

    Can you clarify that we kill only 1 of the tasks and expect the entire task group to be
killed?



src/tests/slave_tests.cpp
Lines 4934-4935 (patched)
<https://reviews.apache.org/r/65369/#comment276234>

    Can you clarify that we kill only 1 of the tasks and expect the entire task group to be
killed?



src/tests/slave_tests.cpp
Lines 4951 (patched)
<https://reviews.apache.org/r/65369/#comment276230>

    executor


- Benjamin Mahler


On Jan. 27, 2018, 2:06 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65369/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2018, 2:06 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test verifies that the v1 executor is shutdown if all of its
> initial tasks could not be delivered, even after the executor has been
> subscribed. See MESOS-8411.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 20b874481d3818574731fc30ba9df1fc2bcbe900 
> 
> 
> Diff: https://reviews.apache.org/r/65369/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message