mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 65362: Added a method to increment invalid scheduler API call counters.
Date Tue, 30 Jan 2018 19:33:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65362/#review196524
-----------------------------------------------------------




src/master/metrics.cpp
Lines 498-506 (patched)
<https://reviews.apache.org/r/65362/#comment276206>

    I wonder if we should also handle the MESSAGE call here? As we noted offline the other
day, all we do in the validation for other messages is ensure that the correct field is set,
but perhaps we should still register the invalid message, since we would increment the metrics
for analogous errors in the ACK calls.


- Greg Mann


On Jan. 26, 2018, 10:08 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65362/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2018, 10:08 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-8184
>     https://issues.apache.org/jira/browse/MESOS-8184
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a method to increment invalid scheduler API call counters.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp c489b6f525f157811549b2cc84addd9d85e87990 
>   src/master/master.cpp b97ebae6ebfd8ae0f73e617d0c55e140b9c3fce7 
>   src/master/metrics.hpp f701efec0a82d6ba72b2414f739fcd1cd7ee2491 
>   src/master/metrics.cpp 64fc829ac3b58d95fc0bd074571a46518a80bbba 
> 
> 
> Diff: https://reviews.apache.org/r/65362/diff/1/
> 
> 
> Testing
> -------
> 
> `make check` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message