mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <>
Subject Re: Review Request 65127: Windows: Enabled docker health checks.
Date Tue, 30 Jan 2018 10:18:13 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 30, 2018, 10:18 a.m.)

Review request for mesos, Alexander Rukletsov and Andrew Schwartzmeyer.


Separated this patch from the one to fix quoting in `docker exec`.

Bugs: MESOS-8498

Repository: mesos

Description (updated)

The network health checks called curl and then executed setns to
enter to container network namespace, which did not work on Windows.
To do the equivalent, Windows nows calls docker run with powershell's
curl equivalent (Invoke-WebRequest) and uses the
network=container:<ID> flag to enter the container's namespace. The
command health check was trivially fixed by replacing the hardcoded
`sh -c`.

Diffs (updated)

  src/checks/checker_process.hpp 510f3b2e6e689faaf26595214ce377c2b5518f28 
  src/checks/checker_process.cpp ddb197b8cc2c503fef5ae20af32f5881fff9833f 





Akash Gupta

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message