mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 65409: Fixed `SlaveRecoveryTest.ReconcileTasksMissingFromSlave`.
Date Mon, 29 Jan 2018 22:18:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65409/#review196479
-----------------------------------------------------------



PASS: Mesos patch 65409 was successfully built and tested.

Reviews applied: `['65397', '65398', '65399', '65400', '65401', '65402', '65403', '65404',
'65405', '65406', '65407', '65408', '65409']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65409

- Mesos Reviewbot Windows


On Jan. 29, 2018, 9:45 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65409/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2018, 9:45 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Gaston Kleiman, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-6713
>     https://issues.apache.org/jira/browse/MESOS-6713
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Because it is not possible to delete a file (or a folder recursively)
> with open handles on Windows, we have to explicitly `reset()` the agent
> before removing the framework meta directory. Otherwise, the task status
> update manager will be destructed too late, and so an open handle for
> `task.updates` will cause the `os::rmdir` to fail.
> 
> This is safe because we previously destructed the agent anyway, just
> later in the test when it was reassigned.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_recovery_tests.cpp 6dcbedb94a2c7b3d65770fc89920c0cad1298d1f 
> 
> 
> Diff: https://reviews.apache.org/r/65409/diff/1/
> 
> 
> Testing
> -------
> 
> make check on CentOS 7, all passed
> ctest on Windows, all passed including new SlaveRecoveryTests
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message