mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 65357: Made devolving `v1::scheduler::Call::SUBSCRIBE` more robust.
Date Mon, 29 Jan 2018 21:26:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65357/#review196469
-----------------------------------------------------------


Ship it!




Ship It!

- Greg Mann


On Jan. 26, 2018, 10:08 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65357/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2018, 10:08 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-8184
>     https://issues.apache.org/jira/browse/MESOS-8184
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `devolve(const v1::scheduler::Call& call)` is called by
> `master::receive()` and by `Master::Http::scheduler()` before the input
> is validated, so it should check if optional fields are set before
> accessing them.
> 
> 
> Diffs
> -----
> 
>   src/internal/devolve.cpp 1cfbdf2ab58cf64ca0947c2dbc8e7f244c912fbe 
> 
> 
> Diff: https://reviews.apache.org/r/65357/diff/1/
> 
> 
> Testing
> -------
> 
> `make check` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message