mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Re: Review Request 65393: Fixed docker command health check to use the right docker socket.
Date Mon, 29 Jan 2018 21:04:22 GMT


> On Jan. 29, 2018, 9 p.m., Andrew Schwartzmeyer wrote:
> > src/docker/executor.cpp
> > Lines 623-624 (patched)
> > <https://reviews.apache.org/r/65393/diff/1/?file=1949979#file1949979line623>
> >
> >     Any chance this could break a Linux deployment?

I don't think anything would break, but the mesosphere people probably would know better.
The "-H" flag is used throughout the rest of the docker code like in `docker->run`, so
now matches those functions.


- Akash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65393/#review196464
-----------------------------------------------------------


On Jan. 29, 2018, 6:20 p.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65393/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2018, 6:20 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and Gaston Kleiman.
> 
> 
> Bugs: MESOS-8498
>     https://issues.apache.org/jira/browse/MESOS-8498
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The original command health check was calling `docker exec` instead
> of `docker -H <docker_socket> exec`, so it was ignoring the socket
> value passed to the docker executor.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp d9e71f8841a868082170d28fc4f3d495e2eb1e61 
>   src/docker/executor.cpp e4c53d558e414e50b1c429fba8e31e504c63744a 
> 
> 
> Diff: https://reviews.apache.org/r/65393/diff/1/
> 
> 
> Testing
> -------
> 
> ran mesos-tests --docker flag.
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message