mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Review Request 65402: Windows: Use Unicode API to duplicate sockets.
Date Mon, 29 Jan 2018 20:35:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65402/
-----------------------------------------------------------

Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu.


Repository: mesos


Description
-------

The CRT API for duplicating file handles is left as-is because
`WindowsFD` currently gets a CRT `int` file descriptor, which
necessitates using `_dup` instead of `DuplicateHandle`. Furthermore, the
latter API does not appear compatible with handles used to redirect
stdout/stderr/stdin for subprocesses.


Diffs
-----

  3rdparty/stout/include/stout/os/windows/dup.hpp b37aaa6429e0e7b4340e86c078f5c543e443bdcd



Diff: https://reviews.apache.org/r/65402/diff/1/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message