mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 65351: Reordered roles in Web UI to display them alphabetically by default.
Date Mon, 29 Jan 2018 19:25:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65351/#review196455
-----------------------------------------------------------


Ship it!





src/webui/master/static/js/app.js
Line 276 (original), 276 (patched)
<https://reviews.apache.org/r/65351/#comment276110>

    Does true represent descending? Seems we should comment this for the reader.


- Benjamin Mahler


On Jan. 26, 2018, 3:16 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65351/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2018, 3:16 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-8495
>     https://issues.apache.org/jira/browse/MESOS-8495
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Use the alphabetical order of the name of the roles by
> default to display their hierarchy straightforwardly.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/js/app.js 463c563cd121e881f7d137123534a047c5e420d2 
>   src/webui/master/static/roles.html 7578852e4e2ad29a0f07e16dcff85af6a2255b02 
> 
> 
> Diff: https://reviews.apache.org/r/65351/diff/1/
> 
> 
> Testing
> -------
> 
> ```
> $ bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --webui_dir='/Users/Armand/Code/apache-mesos/src/webui'
--log_dir='/tmp/master1-log' --weights="example=42,example/a=2" --registry=in_memory
> ```
> UI before patch when viewing the roles tab:
> ![Old UI](https://i.imgur.com/dflxj11.png)
> UI by default after patch:
> ![New UI](https://i.imgur.com/PRyAwNs.png)
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message