mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Review Request 65376: Reverted `protobuf::read(path)` to return `Result<T>`.
Date Mon, 29 Jan 2018 07:55:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65376/
-----------------------------------------------------------

Review request for mesos, Chun-Hung Hsiao and Jie Yu.


Bugs: MESOS-8481
    https://issues.apache.org/jira/browse/MESOS-8481


Repository: mesos


Description
-------

Due to the performance hits of `fsync`, the current implementation
of `state::checkpoint` does not invoke `fsync` prior to `rename`.

As a result, according to this blog post:

  https://thunk.org/tytso/blog/2009/03/12/delayed-allocation-and-
  the-zero-length-file-problem/

If the agent machine crashes after `rename` is called but before
the buffer has been flushed, the file will end up being empty.

This reverts commit 4f9cda17e1a747bc3c4ab3667569304e09600b29.


Diffs
-----

  3rdparty/stout/include/stout/protobuf.hpp 7e7659814a5d95c41c4dfabb5669fd061dff4716 


Diff: https://reviews.apache.org/r/65376/diff/1/


Testing
-------


Thanks,

Michael Park


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message