mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 65375: Added move construction and assignment to Future.
Date Mon, 29 Jan 2018 03:45:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65375/#review196399
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/include/process/future.hpp
Lines 116-117 (patched)
<https://reviews.apache.org/r/65375/#comment276021>

    We shouldn't need these, as the copy/move assignment operators will cover these scenarios
already.
    For example, we don't define these for `Option` and `Try`.


- Michael Park


On Jan. 28, 2018, 6:29 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65375/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2018, 6:29 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-2922
>     https://issues.apache.org/jira/browse/MESOS-2922
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> * Includes using `default` where applicable.
> * Includes assignment operators from `const T&` and `T&&`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/future.hpp 2b8a0590e2e1708be5471fb5530194204b1fcdf1

> 
> 
> Diff: https://reviews.apache.org/r/65375/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message