mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 65372: Replaced the `Os.Which` test to use `cat` rather than `ping`.
Date Sun, 28 Jan 2018 22:05:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65372/#review196393
-----------------------------------------------------------


Ship it!




I wonder what we should do with other parts of Mesos depending on "ping"? We do seem to rely
on the existence of `ping` in `src/tests/containerizer/capabilities_test_helper.cpp`.

- Till Toenshoff


On Jan. 28, 2018, 9:48 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65372/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2018, 9:48 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Starting from Ubuntu 15.04, `ping` is not installed by default.
> Rather than inducing a silly dependency, we'll test with `cat` instead.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/tests/os_tests.cpp 11f17206688e09e86706d2d57d029f1c29d35e0d 
> 
> 
> Diff: https://reviews.apache.org/r/65372/diff/1/
> 
> 
> Testing
> -------
> 
> Successfully ran:
> ```bash
> OS=ubuntu:16.04 COMPILER=gcc CONFIGURATION="--verbose --disable-libtool-wrappers" JOBS=32
BUILDTOOL=autotools ENVIRONMENT="GLOG_v=1 MESOS_VERBOSE=1" support/docker-build.sh
> ```
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message