mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Review Request 65368: Updated maintenance schedule logic.
Date Sat, 27 Jan 2018 01:40:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65368/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-7882
    https://issues.apache.org/jira/browse/MESOS-7882


Repository: mesos


Description
-------

This moves most of the conditional logic of maintenance schedules
into the master's `updateUnavailability` method, while the HTTP
handler will only loop through all MachineIDs once.

The `updateUnavailability` method will now check if the given
Unavailability has changed before it updates the allocator.  This will
prevent a maintenance schedule from rescinding offers unrelated to the
maintenance schedule.


Diffs
-----

  src/master/http.cpp c489b6f525f157811549b2cc84addd9d85e87990 
  src/master/master.cpp b97ebae6ebfd8ae0f73e617d0c55e140b9c3fce7 


Diff: https://reviews.apache.org/r/65368/diff/1/


Testing
-------

make check


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message