mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gaston Kleiman <gas...@mesosphere.io>
Subject Review Request 65359: Added an extra CHECK to `Master::acknowledge()`.
Date Fri, 26 Jan 2018 22:08:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65359/
-----------------------------------------------------------

Review request for mesos and Greg Mann.


Bugs: MESOS-8184
    https://issues.apache.org/jira/browse/MESOS-8184


Repository: mesos


Description
-------

The acknowledge call is validated before being passed to
`Master::acknowledge`, so it is safe to assume that `acknowledge.uuid()`
will be valid.

Added a CHECK to detect problems in the validation code or changes in
the code paths.


Diffs
-----

  src/master/master.cpp b97ebae6ebfd8ae0f73e617d0c55e140b9c3fce7 


Diff: https://reviews.apache.org/r/65359/diff/1/


Testing
-------

`make check` on GNU/Linux


Thanks,

Gaston Kleiman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message