mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Review Request 65348: Fixed flakyness of MasterTest.UpdateSlaveMessageWithPendingOffers.
Date Fri, 26 Jan 2018 12:55:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65348/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov and Benjamin Bannier.


Bugs: MESOS-8490
    https://issues.apache.org/jira/browse/MESOS-8490


Repository: mesos


Description
-------

Under rare circumstances, the clock would have to be advanced to trigger
a new allocation cycle after 'UPDATE_SLAVE' has been handled in the
master. We also wait for old offers to be rescinded before waiting for
updated offers as sometimes the old offer could be received erroneously.


Diffs
-----

  src/tests/master_tests.cpp 4a284c4e9c26b39d1e88b405f8b904f43b902b02 


Diff: https://reviews.apache.org/r/65348/diff/1/


Testing
-------

make check

`src/mesos-tests --gtest_filter=MasterTest.UpdateSlaveMessageWithPendingOffers --gtest_repeat=10000
--gtest_break_on_failure` while running `stress -c 4 -i 8 -m 2 -d 6` on a 4 core machine.
It usually takes a few thousand iterations to trigger the flakyness in the old code. And only
when the host is under heavy load.


Thanks,

Jan Schlicht


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message