mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Review Request 65347: Added missing protobuf include.
Date Fri, 26 Jan 2018 11:41:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65347/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos


Description
-------

When using our bundled version of protobuf, this file is transitively
included from other headers.

However, when building against olders versions of protobuf this fails,
for example when building against the system-default protobuf 3.0
on Ubuntu 17.04.


Diffs
-----

  src/common/protobuf_utils.hpp 0ff7239dd6b8f74119fdd97531d94af21fd0500c 


Diff: https://reviews.apache.org/r/65347/diff/1/


Testing
-------

Built without bundled protobuf on an Ubuntu system.

Started internal CI run: https://jenkins.mesosphere.com/service/jenkins/job/mesos/job/Mesos_CI/2675/


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message