mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 64574: Updated libprocess routing to treat trailing '/' as insignificant.
Date Thu, 25 Jan 2018 19:03:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64574/
-----------------------------------------------------------

(Updated Jan. 25, 2018, 7:03 p.m.)


Review request for mesos, Benjamin Bannier and Benjamin Mahler.


Bugs: MESOS-5333
    https://issues.apache.org/jira/browse/MESOS-5333


Repository: mesos


Description
-------

Prior to this patch, adding a trailing '/' to a valid URL path, e.g.,
"/state/", yielded a 404 response. This patch ensures that two URLs
which differ only in trailing '/' produce the same result.

This is achieved by (1) trimming a trailing '/' when processing a
request and (2) disallowing `route()` calls from using `/`.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/process.hpp 8b8323f5fb4617aa9c22bbdb56af3d1cb0b06ea3

  3rdparty/libprocess/src/process.cpp 52b492749a6f4f019e147e69e94c7cef2eaee8da 
  3rdparty/libprocess/src/tests/http_tests.cpp f79d366baecc73e6b14df593a906264f5fd1d72b 


Diff: https://reviews.apache.org/r/64574/diff/3/

Changes: https://reviews.apache.org/r/64574/diff/2-3/


Testing
-------

Ensured the modified test fails without the fix.
`make check` on Mac OS 10.11.6 and several Linux distributions.


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message