mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 65322: Made `numify` less dependent on `boost::lexical_cast` failure behavior.
Date Thu, 25 Jan 2018 14:32:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65322/
-----------------------------------------------------------

(Updated Jan. 25, 2018, 3:32 p.m.)


Review request for mesos, Benno Evers, Till Toenshoff, and Cong Wang.


Changes
-------

Addressed comments from Benno.


Bugs: MESOS-8484
    https://issues.apache.org/jira/browse/MESOS-8484


Repository: mesos


Description
-------

Previously we relied on Boost to never successfully parse hexadecimal
numbers, and only performed rejection of hexadecimal floating point
numbers before entering our custom parser for hexadecimal numbers.
This was not reliable as on some platforms `boost::lexical_cast` ended
up successfully parsing literals of hexadecimal floating point numbers
leading us to never rejecting hexadecimal floating point numbers.

This patch moves the rejection of hexadecimal floating point numbers
to a point before attempting a parse with `boost::lexical_cast`. While
this decouples us in some regards from Boost's parsing behavior, we
also might end up performing more work than needed. Should this become
a concern we should revisit and optimize the implementation here.


Diffs (updated)
-----

  3rdparty/stout/include/stout/numify.hpp 6db9a78145b7e90cc975786ca83f7acb7fdc3e0a 


Diff: https://reviews.apache.org/r/65322/diff/2/

Changes: https://reviews.apache.org/r/65322/diff/1-2/


Testing
-------

`make check` on a collection of Linux, macos and Windows setups in internal CI.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message