mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <>
Subject Re: Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode.
Date Thu, 25 Jan 2018 08:40:49 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 25, 2018, 9:40 a.m.)

Review request for mesos, Armand Grillet and Kevin Klues.


Fixed handling of strings containing characters requiring escaping or literal quotes.

Bugs: MESOS-8447

Repository: mesos


This patch adds a shell command to create a file containing the commit
message for dry-run mode. To minimize platform differences we use
`printf` instead of `echo`. We output the message on a single line
for compactness.

Diffs (updated)

  support/ 0ef28cb02bc65acfeb7ea6808f74e1620a8a85c4 




Redirected output of ` --dry-run` to a file and successfully applied its output
with `sh`.


Benjamin Bannier

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message