mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 65298: Split test flags into header and source files.
Date Thu, 25 Jan 2018 07:49:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65298/#review196218
-----------------------------------------------------------




src/tests/flags.hpp
Line 23 (original)
<https://reviews.apache.org/r/65298/#comment275764>

    Since we are cleaning this up anyway, let's add missing includes (`stout/option.hpp`).



src/tests/flags.cpp
Lines 18 (patched)
<https://reviews.apache.org/r/65298/#comment275765>

    Let's add missing includes (`stout/result.hpp`).


- Benjamin Bannier


On Jan. 23, 2018, 10:58 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65298/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2018, 10:58 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Gaston Kleiman.
> 
> 
> Bugs: MESOS-7016
>     https://issues.apache.org/jira/browse/MESOS-7016
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Split the test flags into header and source files to reduce the amount
> of recompilation necessary when the implementation changes.
> 
> 
> Diffs
> -----
> 
>   src/tests/flags.hpp df4d4588f405ea884bb89021264e70218e054fae 
>   src/tests/flags.cpp 4542f3443830474edd97e8b695af0c61685e947c 
> 
> 
> Diff: https://reviews.apache.org/r/65298/diff/1/
> 
> 
> Testing
> -------
> 
> make check (Fedora 27)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message