mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 65202: Adopted the libprocess `DEFAULT_TEST_TIMEOUT`.
Date Thu, 25 Jan 2018 07:48:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65202/#review196219
-----------------------------------------------------------




src/tests/fetcher_cache_tests.cpp
Lines 77 (patched)
<https://reviews.apache.org/r/65202/#comment275766>

    Could you include `process/gtest.hpp` here?



src/tests/flags.hpp
Lines 47 (patched)
<https://reviews.apache.org/r/65202/#comment275767>

    Let's include `stout/duration.hpp`.



src/tests/flags.cpp
Lines 164 (patched)
<https://reviews.apache.org/r/65202/#comment275768>

    Let's include `process/gtest.hpp` for this one.



src/tests/gc_tests.cpp
Line 992 (original), 992 (patched)
<https://reviews.apache.org/r/65202/#comment275769>

    Could you include `process/gtest.hpp` here?



src/tests/main.cpp
Lines 107 (patched)
<https://reviews.apache.org/r/65202/#comment275770>

    Could you include `process/gtest.hpp` here?



src/tests/master_contender_detector_tests.cpp
Line 472 (original), 472 (patched)
<https://reviews.apache.org/r/65202/#comment275771>

    Could you include `process/gtest.hpp` here?



src/tests/slave_recovery_tests.cpp
Line 939 (original), 939 (patched)
<https://reviews.apache.org/r/65202/#comment275772>

    Could you include `process/gtest.hpp` here?



src/tests/slave_tests.cpp
Line 8270 (original), 8270 (patched)
<https://reviews.apache.org/r/65202/#comment275773>

    Could you include `process/gtest.hpp` here?


- Benjamin Bannier


On Jan. 23, 2018, 10:58 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65202/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2018, 10:58 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Gaston Kleiman.
> 
> 
> Bugs: MESOS-7016
>     https://issues.apache.org/jira/browse/MESOS-7016
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Rather than hard-coding a 15sec test timeout, use the libprocess
> `DEFAULT_TEST_TIMEOUT` variable so that this can be globally
> tuned. Added a test flag `--default_timeout` that can be used
> to set the `DEFAULT_TEST_TIMEOUT` on a test run.
> 
> 
> Diffs
> -----
> 
>   src/tests/agent_container_api_tests.cpp 618569277545205017320aaf1f3a70e540d35e30 
>   src/tests/containerizer/cgroups_isolator_tests.cpp 5412a7eccaa836a7f182772f1eb33b10298c96a1

>   src/tests/containerizer/xfs_quota_tests.cpp d761ea46fd4f12c6bed74090bf5ead7587f16811

>   src/tests/disk_quota_tests.cpp 4e25e32bf784ea818e18497fe3ebc9f94c5861ff 
>   src/tests/fetcher_cache_tests.cpp 7db7b7dcef27b1686ccae5a7408ff2811a3b9255 
>   src/tests/flags.hpp df4d4588f405ea884bb89021264e70218e054fae 
>   src/tests/flags.cpp 4542f3443830474edd97e8b695af0c61685e947c 
>   src/tests/gc_tests.cpp 0e34c017f2c629b527915218f517b88d8392aa4b 
>   src/tests/main.cpp f945ac9e8858998174b4c2785f6a5612bae66a41 
>   src/tests/master_contender_detector_tests.cpp 015d310b72a152829641d436f7cb558f72dfd77c

>   src/tests/registrar_tests.cpp cbb58c1cd72dc13ed16b5465452d17526255c763 
>   src/tests/slave_recovery_tests.cpp 6d8a57138903637d3cf9e5b19a466961d2c120d7 
>   src/tests/slave_tests.cpp 3a6546b07ac202c461b5c5e8bfcf1eb4f3fe6b4e 
> 
> 
> Diff: https://reviews.apache.org/r/65202/diff/2/
> 
> 
> Testing
> -------
> 
> make check (Fedora 27).
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message