mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 65201: Added a global `DEFAULT_TEST_TIMEOUT` variable.
Date Thu, 25 Jan 2018 07:28:29 GMT


> On Jan. 22, 2018, 10:08 p.m., Benjamin Bannier wrote:
> > 3rdparty/libprocess/include/process/gtest.hpp
> > Line 249 (original), 251 (patched)
> > <https://reviews.apache.org/r/65201/diff/2/?file=1941380#file1941380line251>
> >
> >     We don't really fully qualify the names here, but instead use just `process::...`
elsewhere. Let's stick to that, and potentially clean up globally if we really want it.
> >     
> >     Here and below.

I didn't see the edit replacing `::process::` with `process::`, could you make sure all your
changes are here?


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65201/#review195938
-----------------------------------------------------------


On Jan. 23, 2018, 10:57 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65201/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2018, 10:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Gaston Kleiman.
> 
> 
> Bugs: MESOS-7016
>     https://issues.apache.org/jira/browse/MESOS-7016
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a global `DEFAULT_TEST_TIMEOUT` variable that applications
> can use to globally tune the default timeout in the `AWAIT_READY`
> family of test macros. The default remains 15sec.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am ba9e78148932304ce1961b88e5f97180abd35586 
>   3rdparty/libprocess/include/process/gtest.hpp eee726653d52af2e4a148819e420ebd22e5123a9

>   3rdparty/libprocess/src/CMakeLists.txt f002c157dc2ca64da66bc4e61f5095f2b533ae1f 
>   3rdparty/libprocess/src/gtest.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65201/diff/3/
> 
> 
> Testing
> -------
> 
> make check (Fedora 27).
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message