mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 65223: Removed duplicated "/help" prefix in links in /help response.
Date Thu, 25 Jan 2018 02:53:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65223/#review196197
-----------------------------------------------------------



Hm.. I couldn't really follow from the ticket and desription here what the impact of the bug
is, are there broken links?

I just tested out /help on a cluster and the links are working, so is the issue something
else? What am I missing? :)

- Benjamin Mahler


On Jan. 18, 2018, 5:46 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65223/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2018, 5:46 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-8458
>     https://issues.apache.org/jira/browse/MESOS-8458
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Prior to that patch, links generated as part of the /help endpoint
> response had the "/help/help/<path>" format, which is incorrect.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/help.cpp 4e1faff7e2a0fb73ed444ce645613c98fb513e1c 
> 
> 
> Diff: https://reviews.apache.org/r/65223/diff/1/
> 
> 
> Testing
> -------
> 
> `make check` on MacOS 10.13.2
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message