mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 65000: Added an SLRP test for agent being registered with a new ID.
Date Thu, 25 Jan 2018 01:44:12 GMT


> On Jan. 17, 2018, 7:53 p.m., Greg Mann wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Lines 981 (patched)
> > <https://reviews.apache.org/r/65000/diff/2/?file=1938027#file1938027line981>
> >
> >     s/becomes a pre-existing volume/become pre-existing volumes/

s/volumes/volume/ instead.


> On Jan. 17, 2018, 7:53 p.m., Greg Mann wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Lines 1003-1011 (patched)
> > <https://reviews.apache.org/r/65000/diff/2/?file=1938027#file1938027line1003>
> >
> >     Can you do something like:
> >     
> >     ```
> >     agentFlags.agent_features = SlaveCapabilities();
> >     agentFlags.agent_features->add_capabilities()->set_type(
> >         SlaveInfo::Capability::RESOURCE_PROVIDER);
> >     ```

Did this because `slave::AGENT_CAPABILITIES()` contains a set of capabilities that not yet
become default.


> On Jan. 17, 2018, 7:53 p.m., Greg Mann wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Lines 1039-1040 (patched)
> > <https://reviews.apache.org/r/65000/diff/2/?file=1938027#file1938027line1039>
> >
> >     Same question here as in a previous review, regarding potential raciness of
the first offer. Have you tested this under load?

This is handled by `DeclineOffers` by default.


> On Jan. 17, 2018, 7:53 p.m., Greg Mann wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Lines 1051 (patched)
> > <https://reviews.apache.org/r/65000/diff/2/?file=1938027#file1938027line1051>
> >
> >     s/volume/volumes/

Fixed by making the subject singular.


> On Jan. 17, 2018, 7:53 p.m., Greg Mann wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Lines 1041-1043 (original), 1240-1242 (patched)
> > <https://reviews.apache.org/r/65000/diff/2/?file=1938027#file1938027line1240>
> >
> >     Are these changes, and the rest below, meant to go in this RR?

Have split them into other patches.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65000/#review195635
-----------------------------------------------------------


On Jan. 25, 2018, 1:44 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65000/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2018, 1:44 a.m.)
> 
> 
> Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
> 
> 
> Bugs: MESOS-8409
>     https://issues.apache.org/jira/browse/MESOS-8409
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added an SLRP test for agent being registered with a new ID.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp 5ac91802e7c79e769c59c8418502ccc9d41f51b4

> 
> 
> Diff: https://reviews.apache.org/r/65000/diff/3/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message